fix(jdbc-sink): relax the check for UPDATE_DELETE op #17289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikeW
added
need-cherry-pick-release-1.9
need-cherry-pick-release-1.10
fuyufjh
approved these changes
Jun 18, 2024
StrikeW
force-pushed
the
siyuan/jdbc-sink-ignore-ud
branch
from
cae66b8 to
4ae9444
Compare
wenym1
approved these changes
Jun 18, 2024
| @@ -185,6 +185,9 @@ impl<F: LogStoreFactory> SinkExecutor<F> { | |||
| && !self.sink_param.downstream_pk.is_empty(); | |||
| // Don't compact chunk for blackhole sink for better benchmark performance. | |||
| let compact_chunk = !self.sink.is_blackhole(); | |||
| tracing::info!("Sink info: sink_id: {} actor_id: {}, need_advance_delete: {}, re_construct_with_sink_pk: {}", | |||
There was a problem hiding this comment.
Can be tracing::info!(sink_id, actor_id, need_advanc_delete, re_construct_with_sink_pk, "sink info") to avoid manually generating the format string.
Not sure why, more context here https://risingwave-labs.slack.com/archives/C06F37346CR/p1718669258478389 |
|
I forgot to add the cherry-pick action for v1.10, I will relabel to trigger the action after #17301 |
lmatz
added
need-cherry-pick-release-1.10
StrikeW
added a commit
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
It should be safe to ignore the
U-op in jdbc sink, since we useUPSERTto deliver events into downstream database which can resolve the inconsistent events.related: #14031
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.